mirror of
https://github.com/sipeed/picoclaw.git
synced 2026-06-12 18:08:54 +00:00
程智超0668000959
bb57e0498c
The SessionManager's background cleanup goroutine previously had no shutdown mechanism. Each call to NewSessionManager() started a ticker goroutine that ran indefinitely. In tests, where multiple SessionManagers are created, this caused goroutine leaks. This commit adds a Stop() method that cleanly shuts down the background cleanup goroutine via a channel. Stop() is safe to call multiple times. All existing tests now call t.Cleanup(sm.Stop) to ensure cleanup.
103 lines
2.1 KiB
Go
103 lines
2.1 KiB
Go
package tools
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
)
|
|
|
|
func TestSessionManager_AddGet(t *testing.T) {
|
|
sm := NewSessionManager()
|
|
t.Cleanup(sm.Stop)
|
|
session := &ProcessSession{
|
|
ID: "test-1",
|
|
Command: "echo hello",
|
|
Status: "running",
|
|
StartTime: 1000,
|
|
}
|
|
|
|
sm.Add(session)
|
|
|
|
got, err := sm.Get("test-1")
|
|
require.NoError(t, err)
|
|
require.Equal(t, "test-1", got.ID)
|
|
}
|
|
|
|
func TestSessionManager_Remove(t *testing.T) {
|
|
sm := NewSessionManager()
|
|
t.Cleanup(sm.Stop)
|
|
session := &ProcessSession{
|
|
ID: "test-1",
|
|
Command: "echo hello",
|
|
Status: "running",
|
|
StartTime: 1000,
|
|
}
|
|
sm.Add(session)
|
|
sm.Remove("test-1")
|
|
|
|
_, err := sm.Get("test-1")
|
|
require.ErrorIs(t, err, ErrSessionNotFound)
|
|
}
|
|
|
|
func TestSessionManager_List(t *testing.T) {
|
|
sm := NewSessionManager()
|
|
t.Cleanup(sm.Stop)
|
|
sm.Add(&ProcessSession{
|
|
ID: "test-1",
|
|
Command: "echo hello",
|
|
Status: "running",
|
|
StartTime: 1000,
|
|
})
|
|
sm.Add(&ProcessSession{
|
|
ID: "test-2",
|
|
Command: "echo world",
|
|
Status: "running",
|
|
StartTime: 1001,
|
|
})
|
|
sm.Add(&ProcessSession{
|
|
ID: "test-3",
|
|
Command: "echo done",
|
|
Status: "done",
|
|
StartTime: 1002,
|
|
})
|
|
|
|
sessions := sm.List()
|
|
require.Len(t, sessions, 3)
|
|
|
|
ids := make(map[string]bool)
|
|
for _, s := range sessions {
|
|
ids[s.ID] = true
|
|
}
|
|
require.True(t, ids["test-1"])
|
|
require.True(t, ids["test-2"])
|
|
require.True(t, ids["test-3"])
|
|
}
|
|
|
|
func TestProcessSession_IsDone(t *testing.T) {
|
|
session := &ProcessSession{Status: "running"}
|
|
require.False(t, session.IsDone())
|
|
|
|
session.Status = "done"
|
|
require.True(t, session.IsDone())
|
|
|
|
session.Status = "exited"
|
|
require.True(t, session.IsDone())
|
|
}
|
|
|
|
func TestProcessSession_ToSessionInfo(t *testing.T) {
|
|
session := &ProcessSession{
|
|
ID: "test-1",
|
|
PID: 12345,
|
|
Command: "echo hello",
|
|
Status: "running",
|
|
StartTime: 1000,
|
|
}
|
|
|
|
info := session.ToSessionInfo()
|
|
require.Equal(t, "test-1", info.ID)
|
|
require.Equal(t, "echo hello", info.Command)
|
|
require.Equal(t, "running", info.Status)
|
|
require.Equal(t, 12345, info.PID)
|
|
require.Equal(t, int64(1000), info.StartedAt)
|
|
}
|