lzh/picoclaw
1
0
Fork 0
mirror of https://github.com/sipeed/picoclaw.git synced 2026-06-12 18:08:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: resolve merge conflicts in wecom error handling

Browse Source 
Combine both shadow variable fix (readErr) and proper error
classification (ClassifySendError) in wecom app and bot channels.
This commit is contained in:
Yasuhiro Matsumoto
2026-03-05 22:01:32 +09:00
parent b878272962
commit 03d6ad420f
2 changed files with 11 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
pkg/channels/wecom/app.go
+7 -15
View File
@@ -321,17 +321,12 @@ func (c *WeComAppChannel) uploadMedia(ctx context.Context, accessToken, mediaTyp
defer resp.Body.Close()
if resp.StatusCode != http.StatusOK {
<<<<<<< HEAD
respBody, err := io.ReadAll(resp.Body)
if err != nil {
return "", channels.ClassifySendError(resp.StatusCode, fmt.Errorf("reading wecom upload error response: %w", err))
=======
respBody, readErr := io.ReadAll(resp.Body)
if readErr != nil {
return "", fmt.Errorf(
"reading wecom upload error response: %w", readErr,
return "", channels.ClassifySendError(
resp.StatusCode,
fmt.Errorf("reading wecom upload error response: %w", readErr),
)
>>>>>>> 908fa8d (fix: resolve govet shadow and golines lint errors in wecom channels)
}
return "", channels.ClassifySendError(
resp.StatusCode,
@@ -385,15 +380,12 @@ func (c *WeComAppChannel) sendWeComMessage(ctx context.Context, accessToken stri
defer resp.Body.Close()
if resp.StatusCode != http.StatusOK {
<<<<<<< HEAD
respBody, err := io.ReadAll(resp.Body)
if err != nil {
return channels.ClassifySendError(resp.StatusCode, fmt.Errorf("reading wecom_app error response: %w", err))
=======
respBody, readErr := io.ReadAll(resp.Body)
if readErr != nil {
return fmt.Errorf("reading wecom_app error response: %w", readErr)
>>>>>>> 908fa8d (fix: resolve govet shadow and golines lint errors in wecom channels)
return channels.ClassifySendError(
resp.StatusCode,
fmt.Errorf("reading wecom_app error response: %w", readErr),
)
}
return channels.ClassifySendError(
resp.StatusCode,
pkg/channels/wecom/bot.go
+4 -7
View File
@@ -453,15 +453,12 @@ func (c *WeComBotChannel) sendWebhookReply(ctx context.Context, userID, content
defer resp.Body.Close()
if resp.StatusCode != http.StatusOK {
<<<<<<< HEAD
body, err := io.ReadAll(resp.Body)
if err != nil {
return channels.ClassifySendError(resp.StatusCode, fmt.Errorf("reading webhook error response: %w", err))
=======
body, readErr := io.ReadAll(resp.Body)
if readErr != nil {
return fmt.Errorf("reading webhook error response: %w", readErr)
>>>>>>> 908fa8d (fix: resolve govet shadow and golines lint errors in wecom channels)
return channels.ClassifySendError(
resp.StatusCode,
fmt.Errorf("reading webhook error response: %w", readErr),
)
}
return channels.ClassifySendError(
resp.StatusCode,