mirror of
https://github.com/sipeed/picoclaw.git
synced 2026-06-12 18:08:54 +00:00
Jared Mahotiere
c4cbb5fb35
Phase 1: centralize protocol message/tool/response types in protocoltypes and keep compatibility aliases in providers and protocol packages. Phase 1: preserve HTTPProvider constructor compatibility and route Anthropic api_base through factory auth/provider constructors with base URL normalization. Phase 2: expand provider routing/auth tests (deepseek/nvidia/shengsuanyun, codex/claude oauth/codex-cli) and add openai_compat + anthropic coverage for proxy transport, model normalization, numeric option coercion, token-source refresh, and base URL behavior. Phase 3: apply gofmt and validate with Dockerized tests (go test ./pkg/providers/... ./pkg/migrate and go test ./...).
300 lines
8.8 KiB
Go
300 lines
8.8 KiB
Go
package providers
|
|
|
|
import (
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/sipeed/picoclaw/pkg/auth"
|
|
"github.com/sipeed/picoclaw/pkg/config"
|
|
)
|
|
|
|
func TestResolveProviderSelection(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
setup func(*config.Config)
|
|
wantType providerType
|
|
wantAPIBase string
|
|
wantProxy string
|
|
wantErrSubstr string
|
|
}{
|
|
{
|
|
name: "explicit claude-cli provider routes to cli provider type",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Provider = "claude-cli"
|
|
cfg.Agents.Defaults.Workspace = "/tmp/ws"
|
|
},
|
|
wantType: providerTypeClaudeCLI,
|
|
},
|
|
{
|
|
name: "explicit copilot provider routes to github copilot type",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Provider = "copilot"
|
|
},
|
|
wantType: providerTypeGitHubCopilot,
|
|
wantAPIBase: "localhost:4321",
|
|
},
|
|
{
|
|
name: "explicit deepseek provider uses deepseek defaults",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Provider = "deepseek"
|
|
cfg.Agents.Defaults.Model = "deepseek/deepseek-chat"
|
|
cfg.Providers.DeepSeek.APIKey = "deepseek-key"
|
|
cfg.Providers.DeepSeek.Proxy = "http://127.0.0.1:7890"
|
|
},
|
|
wantType: providerTypeHTTPCompat,
|
|
wantAPIBase: "https://api.deepseek.com/v1",
|
|
wantProxy: "http://127.0.0.1:7890",
|
|
},
|
|
{
|
|
name: "explicit shengsuanyun provider uses defaults",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Provider = "shengsuanyun"
|
|
cfg.Providers.ShengSuanYun.APIKey = "ssy-key"
|
|
cfg.Providers.ShengSuanYun.Proxy = "http://127.0.0.1:7890"
|
|
},
|
|
wantType: providerTypeHTTPCompat,
|
|
wantAPIBase: "https://router.shengsuanyun.com/api/v1",
|
|
wantProxy: "http://127.0.0.1:7890",
|
|
},
|
|
{
|
|
name: "explicit nvidia provider uses defaults",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Provider = "nvidia"
|
|
cfg.Providers.Nvidia.APIKey = "nvapi-test"
|
|
cfg.Providers.Nvidia.Proxy = "http://127.0.0.1:7890"
|
|
},
|
|
wantType: providerTypeHTTPCompat,
|
|
wantAPIBase: "https://integrate.api.nvidia.com/v1",
|
|
wantProxy: "http://127.0.0.1:7890",
|
|
},
|
|
{
|
|
name: "openrouter model uses openrouter defaults",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Model = "openrouter/auto"
|
|
cfg.Providers.OpenRouter.APIKey = "sk-or-test"
|
|
},
|
|
wantType: providerTypeHTTPCompat,
|
|
wantAPIBase: "https://openrouter.ai/api/v1",
|
|
},
|
|
{
|
|
name: "anthropic oauth routes to claude auth provider",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Model = "claude-sonnet-4-5-20250929"
|
|
cfg.Providers.Anthropic.AuthMethod = "oauth"
|
|
},
|
|
wantType: providerTypeClaudeAuth,
|
|
},
|
|
{
|
|
name: "openai oauth routes to codex auth provider",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Model = "gpt-4o"
|
|
cfg.Providers.OpenAI.AuthMethod = "oauth"
|
|
},
|
|
wantType: providerTypeCodexAuth,
|
|
},
|
|
{
|
|
name: "openai codex-cli auth routes to codex cli token provider",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Model = "gpt-4o"
|
|
cfg.Providers.OpenAI.AuthMethod = "codex-cli"
|
|
},
|
|
wantType: providerTypeCodexCLIToken,
|
|
},
|
|
{
|
|
name: "explicit codex-code provider routes to codex cli provider type",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Provider = "codex-code"
|
|
cfg.Agents.Defaults.Workspace = "/tmp/ws"
|
|
},
|
|
wantType: providerTypeCodexCLI,
|
|
},
|
|
{
|
|
name: "zhipu model uses zhipu base default",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Model = "glm-4.7"
|
|
cfg.Providers.Zhipu.APIKey = "zhipu-key"
|
|
},
|
|
wantType: providerTypeHTTPCompat,
|
|
wantAPIBase: "https://open.bigmodel.cn/api/paas/v4",
|
|
},
|
|
{
|
|
name: "groq model uses groq base default",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Model = "groq/llama-3.3-70b"
|
|
cfg.Providers.Groq.APIKey = "gsk-key"
|
|
},
|
|
wantType: providerTypeHTTPCompat,
|
|
wantAPIBase: "https://api.groq.com/openai/v1",
|
|
},
|
|
{
|
|
name: "ollama model uses ollama base default",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Model = "ollama/qwen2.5:14b"
|
|
cfg.Providers.Ollama.APIKey = "ollama-key"
|
|
},
|
|
wantType: providerTypeHTTPCompat,
|
|
wantAPIBase: "http://localhost:11434/v1",
|
|
},
|
|
{
|
|
name: "moonshot model keeps proxy and default base",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Model = "moonshot/kimi-k2.5"
|
|
cfg.Providers.Moonshot.APIKey = "moonshot-key"
|
|
cfg.Providers.Moonshot.Proxy = "http://127.0.0.1:7890"
|
|
},
|
|
wantType: providerTypeHTTPCompat,
|
|
wantAPIBase: "https://api.moonshot.cn/v1",
|
|
wantProxy: "http://127.0.0.1:7890",
|
|
},
|
|
{
|
|
name: "missing keys returns model config error",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Model = "custom-model"
|
|
},
|
|
wantErrSubstr: "no API key configured for model",
|
|
},
|
|
{
|
|
name: "openrouter prefix without key returns provider key error",
|
|
setup: func(cfg *config.Config) {
|
|
cfg.Agents.Defaults.Model = "openrouter/auto"
|
|
},
|
|
wantErrSubstr: "no API key configured for provider",
|
|
},
|
|
}
|
|
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
cfg := config.DefaultConfig()
|
|
tt.setup(cfg)
|
|
|
|
got, err := resolveProviderSelection(cfg)
|
|
if tt.wantErrSubstr != "" {
|
|
if err == nil {
|
|
t.Fatalf("expected error containing %q, got nil", tt.wantErrSubstr)
|
|
}
|
|
if !strings.Contains(err.Error(), tt.wantErrSubstr) {
|
|
t.Fatalf("error = %q, want substring %q", err.Error(), tt.wantErrSubstr)
|
|
}
|
|
return
|
|
}
|
|
|
|
if err != nil {
|
|
t.Fatalf("resolveProviderSelection() error = %v", err)
|
|
}
|
|
if got.providerType != tt.wantType {
|
|
t.Fatalf("providerType = %v, want %v", got.providerType, tt.wantType)
|
|
}
|
|
if tt.wantAPIBase != "" && got.apiBase != tt.wantAPIBase {
|
|
t.Fatalf("apiBase = %q, want %q", got.apiBase, tt.wantAPIBase)
|
|
}
|
|
if tt.wantProxy != "" && got.proxy != tt.wantProxy {
|
|
t.Fatalf("proxy = %q, want %q", got.proxy, tt.wantProxy)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func TestCreateProviderReturnsHTTPProviderForOpenRouter(t *testing.T) {
|
|
cfg := config.DefaultConfig()
|
|
cfg.Agents.Defaults.Model = "openrouter/auto"
|
|
cfg.Providers.OpenRouter.APIKey = "sk-or-test"
|
|
|
|
provider, err := CreateProvider(cfg)
|
|
if err != nil {
|
|
t.Fatalf("CreateProvider() error = %v", err)
|
|
}
|
|
|
|
if _, ok := provider.(*HTTPProvider); !ok {
|
|
t.Fatalf("provider type = %T, want *HTTPProvider", provider)
|
|
}
|
|
}
|
|
|
|
func TestCreateProviderReturnsCodexCliProviderForCodexCode(t *testing.T) {
|
|
cfg := config.DefaultConfig()
|
|
cfg.Agents.Defaults.Provider = "codex-code"
|
|
|
|
provider, err := CreateProvider(cfg)
|
|
if err != nil {
|
|
t.Fatalf("CreateProvider() error = %v", err)
|
|
}
|
|
|
|
if _, ok := provider.(*CodexCliProvider); !ok {
|
|
t.Fatalf("provider type = %T, want *CodexCliProvider", provider)
|
|
}
|
|
}
|
|
|
|
func TestCreateProviderReturnsCodexProviderForCodexCliAuthMethod(t *testing.T) {
|
|
cfg := config.DefaultConfig()
|
|
cfg.Agents.Defaults.Provider = "openai"
|
|
cfg.Providers.OpenAI.AuthMethod = "codex-cli"
|
|
|
|
provider, err := CreateProvider(cfg)
|
|
if err != nil {
|
|
t.Fatalf("CreateProvider() error = %v", err)
|
|
}
|
|
|
|
if _, ok := provider.(*CodexProvider); !ok {
|
|
t.Fatalf("provider type = %T, want *CodexProvider", provider)
|
|
}
|
|
}
|
|
|
|
func TestCreateProviderReturnsClaudeProviderForAnthropicOAuth(t *testing.T) {
|
|
originalGetCredential := getCredential
|
|
t.Cleanup(func() { getCredential = originalGetCredential })
|
|
|
|
getCredential = func(provider string) (*auth.AuthCredential, error) {
|
|
if provider != "anthropic" {
|
|
t.Fatalf("provider = %q, want anthropic", provider)
|
|
}
|
|
return &auth.AuthCredential{
|
|
AccessToken: "anthropic-token",
|
|
}, nil
|
|
}
|
|
|
|
cfg := config.DefaultConfig()
|
|
cfg.Agents.Defaults.Provider = "anthropic"
|
|
cfg.Providers.Anthropic.AuthMethod = "oauth"
|
|
cfg.Providers.Anthropic.APIBase = "https://proxy.example.com/v1"
|
|
|
|
provider, err := CreateProvider(cfg)
|
|
if err != nil {
|
|
t.Fatalf("CreateProvider() error = %v", err)
|
|
}
|
|
|
|
claudeProvider, ok := provider.(*ClaudeProvider)
|
|
if !ok {
|
|
t.Fatalf("provider type = %T, want *ClaudeProvider", provider)
|
|
}
|
|
if got := claudeProvider.delegate.BaseURL(); got != "https://proxy.example.com" {
|
|
t.Fatalf("anthropic baseURL = %q, want %q", got, "https://proxy.example.com")
|
|
}
|
|
}
|
|
|
|
func TestCreateProviderReturnsCodexProviderForOpenAIOAuth(t *testing.T) {
|
|
originalGetCredential := getCredential
|
|
t.Cleanup(func() { getCredential = originalGetCredential })
|
|
|
|
getCredential = func(provider string) (*auth.AuthCredential, error) {
|
|
if provider != "openai" {
|
|
t.Fatalf("provider = %q, want openai", provider)
|
|
}
|
|
return &auth.AuthCredential{
|
|
AccessToken: "openai-token",
|
|
AccountID: "acct_123",
|
|
}, nil
|
|
}
|
|
|
|
cfg := config.DefaultConfig()
|
|
cfg.Agents.Defaults.Provider = "openai"
|
|
cfg.Providers.OpenAI.AuthMethod = "oauth"
|
|
|
|
provider, err := CreateProvider(cfg)
|
|
if err != nil {
|
|
t.Fatalf("CreateProvider() error = %v", err)
|
|
}
|
|
|
|
if _, ok := provider.(*CodexProvider); !ok {
|
|
t.Fatalf("provider type = %T, want *CodexProvider", provider)
|
|
}
|
|
}
|