mirror of
https://github.com/sipeed/picoclaw.git
synced 2026-06-12 18:08:54 +00:00
15a70ac45c
* feat(seahorse): implement short-term memory engine of seahorse Add pkg/seahorse/ module implementing a SQLite-backed DAG-based summary hierarchy for context management, ported from lossless-claw's LCM design: - types.go + short_constants.go: core types (Message, Summary, Conversation, ContextItem) and configuration constants (fanout, token targets, thresholds) - migration.go: idempotent DB schema with FTS5 trigram tokenizer for CJK - store.go: full SQLite CRUD (conversations, messages, summaries DAG, context_items with ordinal gap numbering, FTS5 search) - short_engine.go: Engine lifecycle (NewEngine, Ingest, Assemble, Compact), session pattern filtering (ignore/stateless glob→regex compilation), per-session mutex via sync.Map - short_assembler.go: budget-aware context assembly with fresh tail protection (32 messages), oldest-first eviction, summary XML formatting, RebuildContextItems - short_compaction.go: leaf compaction (messages→summary) and condensed compaction (summaries→higher-level summary), 3-level LLM escalation, CompactUntilUnder for emergency overflow - short_retrieval.go: lookupByID, FTS5/LIKE search, recursive expand with token cap - context_seahorse.go: agent.ContextManager adapter, registered as "seahorse", provider↔seahorse message type conversion (ToolCalls, tool_result) * fix(seahorse): correct 3 adapter bugs in context management - TokenCount: use full message (Content+ToolCalls+Media) instead of Content-only - Empty Content: rebuild Content from tool_result Parts when stored empty - Duplicate summaries: summaries only in Summary field, not in History messages - Grep: fix SearchResult.Snippet→Content for summaries - Schema: fix FTS5 SQL uses VIRTUAL TABLE not TEMP TABLE - TestFTS5SQLConstants: verify FTS5 SQL syntax correctness - Test: fix flaky TestCompactLeaf * fix(agent): ingest steering messages into seahorse SQLite Steering messages were only persisted to session JSONL but not ingested into seahorse SQLite, causing them to be missing from context assembly. Added `ts.ingestMessage(turnCtx, al, pm)` call in the steering message injection block alongside the existing JSONL persistence. Test: TestSeahorseSteeringMessageIngested verifies steering messages appear in seahorse SQLite DB after being processed. * fix(seahorse): address 3 blocking bugs from code review - Fix resequenceContextItemsTx scan error handling (store.go:850) Changed `return err` to `return scanErr` to properly propagate scan errors instead of returning nil (which silently corrupts data) - Fix sql.NullString for INTEGER column (store.go:847) Changed `mid` from sql.NullString to sql.NullInt64 since message_id is INTEGER in schema. Removed unnecessary strconv.ParseInt call. - Fix compactCondensed fallback deleting non-candidate items Added ReplaceContextItemsWithSummary method for per-item deletion when candidates are not contiguous in ordinal space. Optimized to use range deletion when candidates are consecutive. * fix(seahorse): pass Budget to Compact for correct condensed threshold Issue #4 from PR review: When Budget was not passed to seahorse.Compact, it defaulted to `tokensBefore * 0.75`, making `tokensBefore > budget` always true and causing condensed compaction to trigger unnecessarily. Changes: - context_seahorse.go: Forward Budget from CompactRequest to CompactInput - loop.go: Pass Budget (ContextWindow) in all 3 Compact calls - Add test verifying condensed is skipped when tokens < threshold - Fix lint issues in store.go and store_test.go * fix(seahorse): add mutex for assembler lazy initialization Issue #5 from PR review: The check-then-create pattern for e.assembler was a data race when multiple goroutines called Assemble() concurrently: if e.assembler == nil { e.assembler = &Assembler{...} } Changes: - Add assemblerMu sync.Mutex to Engine struct - Add initAssemblerOnce() using double-checked locking (same pattern as initCompactionOnce) - Add TestAssemblerLazyInitRace to verify thread-safety * fix(seahorse): handle non-consecutive depths in selectShallowestCondensationCandidate Issue #8 from PR review: the loop iterated depth 0, 1, 2... assuming consecutive keys, but break when key was missing caused deeper depths to never be checked. Fix: collect all existing depth keys, sort, then iterate in order. * fix(seahorse): wrap DeleteMessagesAfterID and appendContextItems in transactions - DeleteMessagesAfterID: wrap all DELETE operations in a transaction for atomicity, remove redundant manual FTS delete (handled by trigger) - appendContextItems: use transaction to fix read-then-write race condition - Add GetMaxOrdinalTx and resolveItemTokenCountTx for transaction-scoped queries - Remove unused resolveItemTokenCount function Fixes PR review issues 6 and 7. * fix(seahorse): derive readable content from Parts and cap CompactUntilUnder iterations - Derive readable content from MessageParts in AddMessageWithParts so FTS5 indexing and summary formatting can access tool call information - formatMessagesForSummary and truncateSummary now fall back to Parts when Content is empty, fixing blank summaries for Part-based messages - Add MaxCompactIterations (20) to prevent CompactUntilUnder infinite loops; exceeded iterations are logged as warnings
262 lines
7.2 KiB
Go
262 lines
7.2 KiB
Go
package seahorse
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/sipeed/picoclaw/pkg/logger"
|
|
)
|
|
|
|
// escapeXML escapes special characters for safe inclusion in XML content.
|
|
func escapeXML(s string) string {
|
|
s = strings.ReplaceAll(s, "&", "&")
|
|
s = strings.ReplaceAll(s, "<", "<")
|
|
s = strings.ReplaceAll(s, ">", ">")
|
|
s = strings.ReplaceAll(s, "\"", """)
|
|
s = strings.ReplaceAll(s, "'", "'")
|
|
return s
|
|
}
|
|
|
|
// resolvedItem is a context item resolved to its full content with token count.
|
|
type resolvedItem struct {
|
|
ordinal int
|
|
itemType string // "message" or "summary"
|
|
message *Message
|
|
summary *Summary
|
|
tokenCount int
|
|
}
|
|
|
|
// Assemble builds budget-constrained context from summaries + messages.
|
|
//
|
|
// Algorithm:
|
|
// 1. Fetch context_items, resolve to full content
|
|
// 2. Split into evictable prefix + protected fresh tail
|
|
// 3. If evictable fits in remaining budget → include all
|
|
// 4. Else walk evictable from newest to oldest, keep while fits
|
|
func (a *Assembler) Assemble(ctx context.Context, convID int64, input AssembleInput) (*AssembleResult, error) {
|
|
items, err := a.store.GetContextItems(ctx, convID)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("get context items: %w", err)
|
|
}
|
|
if len(items) == 0 {
|
|
return &AssembleResult{}, nil
|
|
}
|
|
|
|
// Resolve all items
|
|
resolved := make([]resolvedItem, len(items))
|
|
for i, item := range items {
|
|
r, err := a.resolveItem(ctx, item)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
resolved[i] = r
|
|
}
|
|
|
|
// Split into evictable prefix and protected fresh tail
|
|
tailStart := len(resolved) - FreshTailCount
|
|
if tailStart < 0 {
|
|
tailStart = 0
|
|
}
|
|
evictable := resolved[:tailStart]
|
|
freshTail := resolved[tailStart:]
|
|
|
|
// Calculate fresh tail tokens
|
|
freshTailTokens := 0
|
|
for _, r := range freshTail {
|
|
freshTailTokens += r.tokenCount
|
|
}
|
|
|
|
// Budget-aware selection of evictable items
|
|
remainingBudget := input.Budget - freshTailTokens
|
|
if remainingBudget < 0 {
|
|
// Fresh tail alone exceeds budget - we keep it anyway (design decision)
|
|
// Log for debugging retry/overflow issues
|
|
logger.InfoCF("seahorse", "assemble: fresh tail exceeds budget", map[string]any{
|
|
"budget": input.Budget,
|
|
"fresh_tail_tokens": freshTailTokens,
|
|
"fresh_tail_count": len(freshTail),
|
|
"over_budget_by": freshTailTokens - input.Budget,
|
|
})
|
|
remainingBudget = 0
|
|
}
|
|
|
|
var selected []resolvedItem
|
|
evictableTokens := 0
|
|
for _, r := range evictable {
|
|
evictableTokens += r.tokenCount
|
|
}
|
|
|
|
if evictableTokens <= remainingBudget {
|
|
// All evictable fit
|
|
selected = append(selected, evictable...)
|
|
} else {
|
|
// Walk from newest to oldest, keep while fits
|
|
var kept []resolvedItem
|
|
accum := 0
|
|
for i := len(evictable) - 1; i >= 0; i-- {
|
|
if accum+evictable[i].tokenCount <= remainingBudget {
|
|
kept = append(kept, evictable[i])
|
|
accum += evictable[i].tokenCount
|
|
} else {
|
|
break
|
|
}
|
|
}
|
|
// Reverse to restore chronological order
|
|
for i, j := 0, len(kept)-1; i < j; i, j = i+1, j-1 {
|
|
kept[i], kept[j] = kept[j], kept[i]
|
|
}
|
|
selected = append(selected, kept...)
|
|
}
|
|
|
|
// Combine: selected evictable + fresh tail
|
|
final := append(selected, freshTail...)
|
|
|
|
// Build result
|
|
var messages []Message
|
|
var summaries []Summary
|
|
var sourceIDs []string
|
|
totalTokens := 0
|
|
maxDepth := 0
|
|
condensedCount := 0
|
|
|
|
for _, r := range final {
|
|
totalTokens += r.tokenCount
|
|
if r.itemType == "message" && r.message != nil {
|
|
messages = append(messages, *r.message)
|
|
sourceIDs = append(sourceIDs, fmt.Sprintf("msg:%d", r.message.ID))
|
|
} else if r.itemType == "summary" && r.summary != nil {
|
|
summaries = append(summaries, *r.summary)
|
|
if r.summary.Depth > maxDepth {
|
|
maxDepth = r.summary.Depth
|
|
}
|
|
if r.summary.Kind == SummaryKindCondensed {
|
|
condensedCount++
|
|
}
|
|
}
|
|
}
|
|
|
|
// Build depth-aware system prompt addition
|
|
systemPromptAddition := ""
|
|
if len(summaries) > 0 {
|
|
if maxDepth >= 2 || condensedCount >= 2 {
|
|
systemPromptAddition = "Your context has been heavily compressed through multi-level summarization.\n" +
|
|
"- Do NOT assert specific facts (commands, SHAs, paths, timestamps) from summaries without expanding.\n" +
|
|
"- When uncertain, use expand to recover original detail before making claims.\n" +
|
|
"- Tool escalation: grep \xe2\x86\x92 describe \xe2\x86\x92 expand"
|
|
} else {
|
|
systemPromptAddition = "Some earlier messages have been summarized. Use expand tools to recover details if needed."
|
|
}
|
|
}
|
|
|
|
// Build Summary field: all XML summaries + system prompt addition
|
|
var summaryParts []string
|
|
for _, sum := range summaries {
|
|
if sum.Content == "" {
|
|
continue
|
|
}
|
|
// Load parent IDs for XML formatting
|
|
parentSummaries, err := a.store.GetSummaryParents(ctx, sum.SummaryID)
|
|
if err != nil {
|
|
logger.WarnCF("seahorse", "assemble: get summary parents", map[string]any{
|
|
"summary_id": sum.SummaryID,
|
|
"error": err.Error(),
|
|
})
|
|
}
|
|
var parentIDs []string
|
|
for _, ps := range parentSummaries {
|
|
parentIDs = append(parentIDs, ps.SummaryID)
|
|
}
|
|
summaryParts = append(summaryParts, FormatSummaryXML(&sum, parentIDs))
|
|
}
|
|
summary := strings.Join(summaryParts, "\n\n")
|
|
if systemPromptAddition != "" {
|
|
if summary != "" {
|
|
summary += "\n\n"
|
|
}
|
|
summary += systemPromptAddition
|
|
}
|
|
|
|
return &AssembleResult{
|
|
Messages: messages,
|
|
Summary: summary,
|
|
}, nil
|
|
}
|
|
|
|
// resolveItem loads the full message or summary for a context item.
|
|
func (a *Assembler) resolveItem(ctx context.Context, item ContextItem) (resolvedItem, error) {
|
|
if item.ItemType == "message" {
|
|
msg, err := a.store.GetMessageByID(ctx, item.MessageID)
|
|
if err != nil {
|
|
return resolvedItem{}, err
|
|
}
|
|
tokens := item.TokenCount
|
|
if tokens == 0 {
|
|
tokens = msg.TokenCount
|
|
}
|
|
return resolvedItem{
|
|
ordinal: item.Ordinal,
|
|
itemType: "message",
|
|
message: msg,
|
|
tokenCount: tokens,
|
|
}, nil
|
|
}
|
|
|
|
if item.ItemType == "summary" {
|
|
sum, err := a.store.GetSummary(ctx, item.SummaryID)
|
|
if err != nil {
|
|
return resolvedItem{}, err
|
|
}
|
|
tokens := item.TokenCount
|
|
if tokens == 0 {
|
|
tokens = sum.TokenCount
|
|
}
|
|
return resolvedItem{
|
|
ordinal: item.Ordinal,
|
|
itemType: "summary",
|
|
summary: sum,
|
|
tokenCount: tokens,
|
|
}, nil
|
|
}
|
|
|
|
return resolvedItem{
|
|
ordinal: item.Ordinal,
|
|
itemType: item.ItemType,
|
|
tokenCount: item.TokenCount,
|
|
}, nil
|
|
}
|
|
|
|
// FormatSummaryXML formats a summary as XML for LLM context.
|
|
// This is exported so context managers can format summaries consistently.
|
|
func FormatSummaryXML(s *Summary, parentIDs []string) string {
|
|
// Build time attributes if available
|
|
var attrs string
|
|
if s.EarliestAt != nil {
|
|
attrs += fmt.Sprintf(` earliest_at="%s"`, s.EarliestAt.Format(time.RFC3339))
|
|
}
|
|
if s.LatestAt != nil {
|
|
attrs += fmt.Sprintf(` latest_at="%s"`, s.LatestAt.Format(time.RFC3339))
|
|
}
|
|
|
|
var parentsSection string
|
|
if s.Kind == SummaryKindCondensed && len(parentIDs) > 0 {
|
|
parents := "<parents>\n"
|
|
for _, pid := range parentIDs {
|
|
parents += fmt.Sprintf(" <summary_ref id=\"%s\" />\n", pid)
|
|
}
|
|
parents += " </parents>\n"
|
|
parentsSection = parents
|
|
}
|
|
return fmt.Sprintf(
|
|
"<summary id=\"%s\" kind=\"%s\" depth=\"%d\" descendant_count=\"%d\"%s>\n <content>\n %s\n </content>\n%s</summary>",
|
|
s.SummaryID,
|
|
string(s.Kind),
|
|
s.Depth,
|
|
s.DescendantCount,
|
|
attrs,
|
|
escapeXML(s.Content),
|
|
parentsSection,
|
|
)
|
|
}
|