mirror of
https://github.com/sipeed/picoclaw.git
synced 2026-06-12 18:08:54 +00:00
ian
f3c1162001
* feat(skills): add retry mechanism for HTTP requests Implement a retry mechanism with exponential backoff for HTTP requests in the skill installer. This improves reliability when fetching skills from GitHub by automatically retrying failed requests up to 3 times. Add comprehensive tests to verify retry behavior under different scenarios including success on different attempts and proper delay between retries. * fix: improve http request retry logic with status code checks Add shouldRetry helper function to determine retryable status codes. Close response body between retry attempts and break early for non-retryable status codes. * refactor: remove unused BuiltinSkill struct The struct was not being used anywhere in the codebase, so it's safe to remove it to reduce clutter and improve maintainability. * refactor(http): move retry logic to utils package Extract HTTP retry functionality from skills package to utils for better reusability Add context-aware sleep function and comprehensive tests * refactor(http): extract retry delay unit to variable Extract hardcoded retry delay unit to a variable for better testability and flexibility. Update tests to use milliseconds for faster execution while maintaining the same behavior. * test(http_retry): remove t.Parallel from test cases * test(http_retry): remove redundant test cases for retry success The removed test cases for success on second and third attempts were redundant since the retry logic is already covered by other tests. This simplifies the test suite while maintaining coverage.
121 lines
3.0 KiB
Go
121 lines
3.0 KiB
Go
package skills
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"net/http"
|
|
"os"
|
|
"path/filepath"
|
|
"time"
|
|
|
|
"github.com/sipeed/picoclaw/pkg/utils"
|
|
)
|
|
|
|
type SkillInstaller struct {
|
|
workspace string
|
|
}
|
|
|
|
type AvailableSkill struct {
|
|
Name string `json:"name"`
|
|
Repository string `json:"repository"`
|
|
Description string `json:"description"`
|
|
Author string `json:"author"`
|
|
Tags []string `json:"tags"`
|
|
}
|
|
|
|
func NewSkillInstaller(workspace string) *SkillInstaller {
|
|
return &SkillInstaller{
|
|
workspace: workspace,
|
|
}
|
|
}
|
|
|
|
func (si *SkillInstaller) InstallFromGitHub(ctx context.Context, repo string) error {
|
|
skillDir := filepath.Join(si.workspace, "skills", filepath.Base(repo))
|
|
|
|
if _, err := os.Stat(skillDir); err == nil {
|
|
return fmt.Errorf("skill '%s' already exists", filepath.Base(repo))
|
|
}
|
|
|
|
url := fmt.Sprintf("https://raw.githubusercontent.com/%s/main/SKILL.md", repo)
|
|
|
|
client := &http.Client{Timeout: 15 * time.Second}
|
|
req, err := http.NewRequestWithContext(ctx, "GET", url, nil)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to create request: %w", err)
|
|
}
|
|
|
|
resp, err := utils.DoRequestWithRetry(client, req)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to fetch skill: %w", err)
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
if resp.StatusCode != 200 {
|
|
return fmt.Errorf("failed to fetch skill: HTTP %d", resp.StatusCode)
|
|
}
|
|
|
|
body, err := io.ReadAll(resp.Body)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to read response: %w", err)
|
|
}
|
|
|
|
if err := os.MkdirAll(skillDir, 0o755); err != nil {
|
|
return fmt.Errorf("failed to create skill directory: %w", err)
|
|
}
|
|
|
|
skillPath := filepath.Join(skillDir, "SKILL.md")
|
|
if err := os.WriteFile(skillPath, body, 0o644); err != nil {
|
|
return fmt.Errorf("failed to write skill file: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (si *SkillInstaller) Uninstall(skillName string) error {
|
|
skillDir := filepath.Join(si.workspace, "skills", skillName)
|
|
|
|
if _, err := os.Stat(skillDir); os.IsNotExist(err) {
|
|
return fmt.Errorf("skill '%s' not found", skillName)
|
|
}
|
|
|
|
if err := os.RemoveAll(skillDir); err != nil {
|
|
return fmt.Errorf("failed to remove skill: %w", err)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (si *SkillInstaller) ListAvailableSkills(ctx context.Context) ([]AvailableSkill, error) {
|
|
url := "https://raw.githubusercontent.com/sipeed/picoclaw-skills/main/skills.json"
|
|
|
|
client := &http.Client{Timeout: 15 * time.Second}
|
|
req, err := http.NewRequestWithContext(ctx, "GET", url, nil)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to create request: %w", err)
|
|
}
|
|
|
|
resp, err := utils.DoRequestWithRetry(client, req)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to fetch skills list: %w", err)
|
|
}
|
|
defer resp.Body.Close()
|
|
|
|
if resp.StatusCode != 200 {
|
|
return nil, fmt.Errorf("failed to fetch skills list: HTTP %d", resp.StatusCode)
|
|
}
|
|
|
|
body, err := io.ReadAll(resp.Body)
|
|
if err != nil {
|
|
return nil, fmt.Errorf("failed to read response: %w", err)
|
|
}
|
|
|
|
var skills []AvailableSkill
|
|
if err := json.Unmarshal(body, &skills); err != nil {
|
|
return nil, fmt.Errorf("failed to parse skills list: %w", err)
|
|
}
|
|
|
|
return skills, nil
|
|
}
|