mirror of
https://github.com/sipeed/picoclaw.git
synced 2026-06-12 18:08:54 +00:00
is-Xiaoen
26f623ed32
* feat(session): add SessionStore interface and JSONL backend adapter Extract a SessionStore interface from the methods the agent loop uses (AddMessage, GetHistory, SetSummary, TruncateHistory, Save, etc.). Both SessionManager and the new JSONLBackend satisfy this interface, allowing the persistence layer to be swapped transparently. JSONLBackend wraps memory.Store and maps its error-returning API to the fire-and-forget contract that the agent loop expects — write errors are logged, reads return empty defaults on failure. Save() triggers compaction to reclaim space after logical truncation. Part of #1169 * test(session): add JSONLBackend integration tests 8 tests covering the full SessionStore contract through the JSONL backend: message roundtrip, tool calls, summary, truncation with compaction, history replacement, empty sessions, session isolation, and the complete summarization flow (SetSummary → TruncateHistory → Save). Includes compile-time interface satisfaction checks for both SessionManager and JSONLBackend. Part of #1169 * feat(agent): wire JSONL session store into agent loop Replace the concrete *SessionManager field with the SessionStore interface and initialize the JSONL backend by default. Legacy .json session files are auto-migrated on first startup. Falls back to SessionManager if the JSONL store cannot be initialized. The agent loop code (loop.go) requires zero changes — all method calls work identically through the interface. Closes #1169 * fix(session): propagate compact error from Save Save() was swallowing the error returned by Compact and always returning nil. Callers checking Save's return value would never see a compaction failure. Return the error directly so the agent loop can log or handle it as needed. * feat(session): add Close to SessionStore interface Add Close() error to SessionStore so callers can release resources through the interface. JSONLBackend already had Close; this adds a no-op implementation to SessionManager for compatibility. * fix(session): close session stores on shutdown and harden migration - Add Close() to AgentInstance, AgentRegistry, and AgentLoop so JSONL file handles are released during gateway shutdown and CLI exit. - Fall back to SessionManager when migration fails, preventing a split state where some sessions live in JSONL and others remain in JSON. - Add defer agentLoop.Close() in the CLI agent command path. - Document SessionStore interface methods (fire-and-forget contract).
33 lines
1.4 KiB
Go
33 lines
1.4 KiB
Go
package session
|
|
|
|
import "github.com/sipeed/picoclaw/pkg/providers"
|
|
|
|
// SessionStore defines the persistence operations used by the agent loop.
|
|
// Both SessionManager (legacy JSON backend) and JSONLBackend satisfy this
|
|
// interface, allowing the storage layer to be swapped without touching the
|
|
// agent loop code.
|
|
//
|
|
// Write methods (Add*, Set*, Truncate*) are fire-and-forget: they do not
|
|
// return errors. Implementations should log failures internally. This
|
|
// matches the original SessionManager contract that the agent loop relies on.
|
|
type SessionStore interface {
|
|
// AddMessage appends a simple role/content message to the session.
|
|
AddMessage(sessionKey, role, content string)
|
|
// AddFullMessage appends a complete message including tool calls.
|
|
AddFullMessage(sessionKey string, msg providers.Message)
|
|
// GetHistory returns the full message history for the session.
|
|
GetHistory(key string) []providers.Message
|
|
// GetSummary returns the conversation summary, or "" if none.
|
|
GetSummary(key string) string
|
|
// SetSummary replaces the conversation summary.
|
|
SetSummary(key, summary string)
|
|
// SetHistory replaces the full message history.
|
|
SetHistory(key string, history []providers.Message)
|
|
// TruncateHistory keeps only the last keepLast messages.
|
|
TruncateHistory(key string, keepLast int)
|
|
// Save persists any pending state to durable storage.
|
|
Save(key string) error
|
|
// Close releases resources held by the store.
|
|
Close() error
|
|
}
|