Files
picoclaw/pkg/channels/manager_channel.go
T
程智超0668000959 7338df2cfb fix(channels): check json marshal/unmarshal errors in toChannelHashes
Replace silently discarded json.Marshal and json.Unmarshal errors with
explicit checks. If serialization fails, log a warning and either
return early (for the config-level marshal/unmarshal) or skip the
channel (for per-channel marshal). This prevents silent data loss
when channel configuration contains unexpected types.
2026-06-12 14:18:28 +08:00

175 lines
4.8 KiB
Go

package channels
import (
"crypto/md5"
"encoding/hex"
"encoding/json"
"log"
"github.com/sipeed/picoclaw/pkg/config"
)
func toChannelHashes(cfg *config.Config) map[string]string {
result := make(map[string]string)
ch := cfg.Channels
marshal, err := json.Marshal(ch)
if err != nil {
log.Printf("[manager_channel] failed to marshal channels config: %v", err)
return result
}
var channelConfig map[string]map[string]any
if err := json.Unmarshal(marshal, &channelConfig); err != nil {
log.Printf("[manager_channel] failed to unmarshal channels config: %v", err)
return result
}
for key, value := range channelConfig {
if enabled, ok := value["enabled"].(bool); !ok || !enabled {
continue
}
hiddenValues(key, value, ch.Get(key))
valueBytes, err := json.Marshal(value)
if err != nil {
log.Printf("[manager_channel] failed to marshal channel %s config: %v", key, err)
continue
}
hash := md5.Sum(valueBytes)
result[key] = hex.EncodeToString(hash[:])
}
return result
}
func hiddenValues(key string, value map[string]any, ch *config.Channel) {
v, err := ch.GetDecoded()
if err != nil {
return
}
switch key {
case "pico":
if settings, ok := v.(*config.PicoSettings); ok {
value["token"] = settings.Token.String()
}
case "telegram":
if settings, ok := v.(*config.TelegramSettings); ok {
value["token"] = settings.Token.String()
}
case "discord":
if settings, ok := v.(*config.DiscordSettings); ok {
value["token"] = settings.Token.String()
}
case "slack":
if settings, ok := v.(*config.SlackSettings); ok {
value["bot_token"] = settings.BotToken.String()
value["app_token"] = settings.AppToken.String()
}
case "matrix":
if settings, ok := v.(*config.MatrixSettings); ok {
value["token"] = settings.AccessToken.String()
}
case "onebot":
if settings, ok := v.(*config.OneBotSettings); ok {
value["token"] = settings.AccessToken.String()
}
case "line":
if settings, ok := v.(*config.LINESettings); ok {
value["token"] = settings.ChannelAccessToken.String()
value["secret"] = settings.ChannelSecret.String()
}
case "wecom":
if settings, ok := v.(*config.WeComSettings); ok {
value["secret"] = settings.Secret.String()
}
case "dingtalk":
if settings, ok := v.(*config.DingTalkSettings); ok {
value["secret"] = settings.ClientSecret.String()
}
case "qq":
if settings, ok := v.(*config.QQSettings); ok {
value["secret"] = settings.AppSecret.String()
}
case "irc":
if settings, ok := v.(*config.IRCSettings); ok {
value["password"] = settings.Password.String()
value["serv_password"] = settings.NickServPassword.String()
value["sasl_password"] = settings.SASLPassword.String()
}
case "feishu":
if settings, ok := v.(*config.FeishuSettings); ok {
value["app_secret"] = settings.AppSecret.String()
value["encrypt_key"] = settings.EncryptKey.String()
value["verification_token"] = settings.VerificationToken.String()
}
case "teams_webhook":
// Expose webhook URLs for hash computation (they contain secrets)
vv := value["webhooks"]
webhooks := make(map[string]string)
if vv != nil {
if m, ok := vv.(map[string]string); ok {
webhooks = m
} else if m, ok := vv.(map[string]any); ok {
for k, w := range m {
if s, ok := w.(string); ok {
webhooks[k] = s
}
}
}
}
if settings, ok := v.(*config.TeamsWebhookSettings); ok {
for name, target := range settings.Webhooks {
webhooks[name] = target.WebhookURL.String()
}
}
value["webhooks"] = webhooks
case "mqtt":
if settings, ok := v.(*config.MQTTSettings); ok {
value["username"] = settings.Username.String()
value["password"] = settings.Password.String()
}
case "slack_webhook":
// Expose webhook URLs for hash computation (they contain secrets)
if settings, ok := v.(*config.SlackWebhookSettings); ok {
webhooks := make(map[string]any)
for name, target := range settings.Webhooks {
webhooks[name] = map[string]any{
"webhook_url": target.WebhookURL.String(),
"username": target.Username,
"icon_emoji": target.IconEmoji,
}
}
value["webhooks"] = webhooks
}
}
}
func compareChannels(old, news map[string]string) (added, removed []string) {
for key, newHash := range news {
if oldHash, ok := old[key]; ok {
if newHash != oldHash {
removed = append(removed, key)
added = append(added, key)
}
} else {
added = append(added, key)
}
}
for key := range old {
if _, ok := news[key]; !ok {
removed = append(removed, key)
}
}
return added, removed
}
func toChannelConfig(cfg *config.Config, list []string) (*config.ChannelsConfig, error) {
result := make(config.ChannelsConfig)
for _, name := range list {
bc, ok := cfg.Channels[name]
if !ok || !bc.Enabled {
continue
}
result[name] = bc
}
return &result, nil
}