mirror of
https://github.com/sipeed/picoclaw.git
synced 2026-06-12 18:08:54 +00:00
esubaalew
29e9b6b4b5
The previous dedupe map rotation logic completely cleared the map when it reached max size, causing an 'amnesia cliff' where immediately arriving duplicates of just-forgotten messages would be processed. This change replaces that with a MessageDeduplicator struct that uses a circular queue (ring buffer) to track insertions. When the limit is reached, it only evicts the absolute oldest message from the map, completely resolving the cliff issue. This also cleans up the WeCom Bot and App webhook handlers by encapsulating the mutex and map state.
55 lines
1.3 KiB
Go
55 lines
1.3 KiB
Go
package wecom
|
|
|
|
import "sync"
|
|
|
|
const wecomMaxProcessedMessages = 1000
|
|
|
|
// MessageDeduplicator provides thread-safe message deduplication using a circular queue (ring buffer)
|
|
// combined with a hash map. This ensures fast O(1) lookups while naturally evicting the oldest
|
|
// messages without causing "amnesia cliffs" when the limit is reached.
|
|
type MessageDeduplicator struct {
|
|
mu sync.Mutex
|
|
msgs map[string]bool
|
|
ring []string
|
|
idx int
|
|
max int
|
|
}
|
|
|
|
// NewMessageDeduplicator creates a new deduplicator with the specified capacity.
|
|
func NewMessageDeduplicator(maxEntries int) *MessageDeduplicator {
|
|
if maxEntries <= 0 {
|
|
maxEntries = wecomMaxProcessedMessages
|
|
}
|
|
return &MessageDeduplicator{
|
|
msgs: make(map[string]bool, maxEntries),
|
|
ring: make([]string, maxEntries),
|
|
max: maxEntries,
|
|
}
|
|
}
|
|
|
|
// MarkMessageProcessed marks msgID as processed and returns false for duplicates.
|
|
func (d *MessageDeduplicator) MarkMessageProcessed(msgID string) bool {
|
|
d.mu.Lock()
|
|
defer d.mu.Unlock()
|
|
|
|
// 1. Check for duplicate
|
|
if d.msgs[msgID] {
|
|
return false
|
|
}
|
|
|
|
// 2. Evict the oldest message at our current ring position (if any)
|
|
oldestID := d.ring[d.idx]
|
|
if oldestID != "" {
|
|
delete(d.msgs, oldestID)
|
|
}
|
|
|
|
// 3. Store the new message
|
|
d.msgs[msgID] = true
|
|
d.ring[d.idx] = msgID
|
|
|
|
// 4. Advance the circle queue index
|
|
d.idx = (d.idx + 1) % d.max
|
|
|
|
return true
|
|
}
|