yinwm 474f3dbf90 fix: resolve code review issues in tool-result-refactor ...

1. Remove duplicate ToolResult definition in heartbeat package
   - Import tools.ToolResult instead of local definition
   - Add nil check for handler before execution

2. Fix SpawnTool to return AsyncResult and implement AsyncTool
   - Add callback field and SetCallback method
   - Return AsyncResult instead of NewToolResult

3. Add context cancellation support to SubagentManager
   - Check ctx.Done() before and during task execution
   - Set task status to "cancelled" on cancellation
   - Call callback with result on completion

4. Fix data race window in CronTool.addJob
   - Use Lock instead of RLock for channel/chatID access
   - Ensure consistent snapshot during job creation

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

2026-02-13 01:59:50 +08:00

..

base.go

feat: US-006 - Add AsyncCallback type and AsyncTool interface

2026-02-12 19:35:41 +08:00

cron.go

fix: resolve code review issues in tool-result-refactor

2026-02-13 01:59:50 +08:00

edit_test.go

Merge upstream/main into ralph/tool-result-refactor

2026-02-13 01:00:26 +08:00

edit.go

Merge upstream/main into ralph/tool-result-refactor

2026-02-13 01:00:26 +08:00

filesystem_test.go

* Delete unused file

2026-02-12 21:58:40 +08:00

filesystem.go

Merge upstream/main into ralph/tool-result-refactor

2026-02-13 01:00:26 +08:00

message_test.go

feat: US-011 - Add MessageTool tests

2026-02-12 19:50:53 +08:00

message.go

feat: US-002 - Modify Tool interface to return *ToolResult

2026-02-12 19:28:56 +08:00

registry.go

chore: Clean up Ralph agent tracking files

2026-02-12 23:51:52 +08:00

result_test.go

feat: US-002 - Modify Tool interface to return *ToolResult

2026-02-12 19:28:56 +08:00

result.go

feat: US-002 - Modify Tool interface to return *ToolResult

2026-02-12 19:28:56 +08:00

shell_test.go

Merge upstream/main into ralph/tool-result-refactor

2026-02-13 01:00:26 +08:00

shell.go

Merge upstream/main into ralph/tool-result-refactor

2026-02-13 01:00:26 +08:00

spawn.go

fix: resolve code review issues in tool-result-refactor

2026-02-13 01:59:50 +08:00

subagent_tool_test.go

feat: US-018 - Add SubagentTool with ToolResult support

2026-02-12 20:14:21 +08:00

subagent.go

fix: resolve code review issues in tool-result-refactor

2026-02-13 01:59:50 +08:00

types.go

* First commit

2026-02-09 19:20:19 +08:00

web_test.go

feat: US-014 - Add WebTool tests

2026-02-12 19:54:44 +08:00

web.go

feat: US-002 - Modify Tool interface to return *ToolResult

2026-02-12 19:28:56 +08:00