Files
picoclaw/pkg/utils/tool_feedback_test.go
T
David Siewert 8dca2a1319 fix: improve error handling and nil consistency in FormatArgsJSON
- Use fmt.Sprintf fallback instead of {} on encoding errors
- Normalize nil args to {} in FormatArgsJSON for consistent output
- Update tests to expect {} instead of null for nil args

Based on PR #2670 review feedback from afjcjsbx
2026-04-27 16:05:10 +06:00

157 lines
5.1 KiB
Go

package utils
import (
"encoding/json"
"testing"
)
func TestFormatToolFeedbackMessage(t *testing.T) {
got := FormatToolFeedbackMessage(
"read_file",
"I will read README.md first to confirm the current project structure.",
"{\n \"path\": \"README.md\"\n}",
)
want := "\U0001f527 `read_file`\nI will read README.md first to confirm the current project structure.\n```json\n{\n \"path\": \"README.md\"\n}\n```"
if got != want {
t.Fatalf("FormatToolFeedbackMessage() = %q, want %q", got, want)
}
}
func TestFormatToolFeedbackMessage_EmptyExplanationShowsArgs(t *testing.T) {
got := FormatToolFeedbackMessage("read_file", "", "{\n \"path\": \"README.md\"\n}")
want := "\U0001f527 `read_file`\n```json\n{\n \"path\": \"README.md\"\n}\n```"
if got != want {
t.Fatalf("FormatToolFeedbackMessage() = %q, want %q", got, want)
}
}
func TestFormatToolFeedbackMessage_EmptyToolNameOmitsToolLine(t *testing.T) {
got := FormatToolFeedbackMessage("", "Continue drafting the final response.", "")
want := "Continue drafting the final response."
if got != want {
t.Fatalf("FormatToolFeedbackMessage() = %q, want %q", got, want)
}
}
func TestFormatToolFeedbackMessage_EmptyExplanationAndArgsKeepsOnlyToolLine(t *testing.T) {
got := FormatToolFeedbackMessage("read_file", "", "")
want := "\U0001f527 `read_file`"
if got != want {
t.Fatalf("FormatToolFeedbackMessage() = %q, want %q", got, want)
}
}
func TestFitToolFeedbackMessage_TruncatesBodyWithinSingleMessage(t *testing.T) {
got := FitToolFeedbackMessage(
"\U0001f527 `read_file`\nRead README.md first to confirm the current project structure.",
40,
)
want := "\U0001f527 `read_file`\nRead README.md first to..."
if got != want {
t.Fatalf("FitToolFeedbackMessage() = %q, want %q", got, want)
}
}
func TestFitToolFeedbackMessage_TruncatesSingleLineMessage(t *testing.T) {
got := FitToolFeedbackMessage("\U0001f527 `read_file`", 10)
want := "\U0001f527 `read..."
if got != want {
t.Fatalf("FitToolFeedbackMessage() = %q, want %q", got, want)
}
}
func TestFormatArgsJSON_Defaults(t *testing.T) {
args := map[string]any{"path": "README.md", "line": 42}
got := FormatArgsJSON(args, false, false)
var gotVal, wantVal any
if err := json.Unmarshal([]byte(got), &gotVal); err != nil {
t.Fatalf("FormatArgsJSON() returned invalid JSON: %v", err)
}
want := `{"path":"README.md","line":42}`
if err := json.Unmarshal([]byte(want), &wantVal); err != nil {
t.Fatalf("invalid test want JSON: %v", err)
}
if !jsonValEq(gotVal, wantVal) {
t.Fatalf("FormatArgsJSON() = %q, want %q", got, want)
}
}
func TestFormatArgsJSON_PrettyPrint(t *testing.T) {
args := map[string]any{"path": "README.md", "line": 42}
got := FormatArgsJSON(args, true, false)
var gotVal any
if err := json.Unmarshal([]byte(got), &gotVal); err != nil {
t.Fatalf("FormatArgsJSON() returned invalid JSON: %v", err)
}
want := `{"path":"README.md","line":42}`
var wantVal any
if err := json.Unmarshal([]byte(want), &wantVal); err != nil {
t.Fatalf("invalid test want JSON: %v", err)
}
if !jsonValEq(gotVal, wantVal) {
t.Fatalf("FormatArgsJSON() prettyPrint = %q, want structure %q", got, want)
}
}
func TestFormatArgsJSON_DisableEscapeHTML(t *testing.T) {
args := map[string]any{"msg": "a < b && c > d"}
got := FormatArgsJSON(args, false, true)
var gotVal, wantVal any
want := `{"msg":"a < b && c > d"}`
if err := json.Unmarshal([]byte(got), &gotVal); err != nil {
t.Fatalf("FormatArgsJSON() returned invalid JSON: %v", err)
}
if err := json.Unmarshal([]byte(want), &wantVal); err != nil {
t.Fatalf("invalid test want JSON: %v", err)
}
if !jsonValEq(gotVal, wantVal) {
t.Fatalf("FormatArgsJSON() disableEscapeHTML = %q, want %q", got, want)
}
}
func TestFormatArgsJSON_PrettyPrintAndDisableEscapeHTML(t *testing.T) {
args := map[string]any{"msg": "a < b && c > d"}
got := FormatArgsJSON(args, true, true)
var gotVal, wantVal any
want := `{"msg":"a < b && c > d"}`
if err := json.Unmarshal([]byte(got), &gotVal); err != nil {
t.Fatalf("FormatArgsJSON() returned invalid JSON: %v", err)
}
if err := json.Unmarshal([]byte(want), &wantVal); err != nil {
t.Fatalf("invalid test want JSON: %v", err)
}
if !jsonValEq(gotVal, wantVal) {
t.Fatalf("FormatArgsJSON() combined = %q, want %q", got, want)
}
}
func TestFormatArgsJSON_EscapeHTMLByDefault(t *testing.T) {
args := map[string]any{"msg": "a < b && c > d"}
got := FormatArgsJSON(args, false, false)
var gotVal, wantVal any
want := `{"msg":"a \u003c b \u0026\u0026 c \u003e d"}`
if err := json.Unmarshal([]byte(got), &gotVal); err != nil {
t.Fatalf("FormatArgsJSON() returned invalid JSON: %v", err)
}
if err := json.Unmarshal([]byte(want), &wantVal); err != nil {
t.Fatalf("invalid test want JSON: %v", err)
}
if !jsonValEq(gotVal, wantVal) {
t.Fatalf("FormatArgsJSON() default escape = %q, want %q", got, want)
}
}
func TestFormatArgsJSON_NilArgs(t *testing.T) {
got := FormatArgsJSON(nil, false, false)
want := `{}`
if got != want {
t.Fatalf("FormatArgsJSON() nil = %q, want %q", got, want)
}
}
func jsonValEq(a, b any) bool {
aJSON, _ := json.Marshal(a)
bJSON, _ := json.Marshal(b)
return string(aJSON) == string(bJSON)
}