mirror of
https://github.com/sipeed/picoclaw.git
synced 2026-06-12 18:08:54 +00:00
3501962977
Cover empty content early return, single-message send, multi-chunk splitting for long messages, HTML-to-plain-text fallback per chunk, and error propagation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
236 lines
6.6 KiB
Go
236 lines
6.6 KiB
Go
package telegram
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/mymmrac/telego"
|
|
ta "github.com/mymmrac/telego/telegoapi"
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/sipeed/picoclaw/pkg/bus"
|
|
"github.com/sipeed/picoclaw/pkg/channels"
|
|
)
|
|
|
|
const testToken = "1234567890:aaaabbbbaaaabbbbaaaabbbbaaaabbbbccc"
|
|
|
|
// stubCaller implements ta.Caller for testing.
|
|
type stubCaller struct {
|
|
calls []stubCall
|
|
callFn func(ctx context.Context, url string, data *ta.RequestData) (*ta.Response, error)
|
|
}
|
|
|
|
type stubCall struct {
|
|
URL string
|
|
Data *ta.RequestData
|
|
}
|
|
|
|
func (s *stubCaller) Call(ctx context.Context, url string, data *ta.RequestData) (*ta.Response, error) {
|
|
s.calls = append(s.calls, stubCall{URL: url, Data: data})
|
|
return s.callFn(ctx, url, data)
|
|
}
|
|
|
|
// stubConstructor implements ta.RequestConstructor for testing.
|
|
type stubConstructor struct{}
|
|
|
|
func (s *stubConstructor) JSONRequest(parameters any) (*ta.RequestData, error) {
|
|
return &ta.RequestData{}, nil
|
|
}
|
|
|
|
func (s *stubConstructor) MultipartRequest(parameters map[string]string, files map[string]ta.NamedReader) (*ta.RequestData, error) {
|
|
return &ta.RequestData{}, nil
|
|
}
|
|
|
|
// successResponse returns a ta.Response that telego will treat as a successful SendMessage.
|
|
func successResponse(t *testing.T) *ta.Response {
|
|
t.Helper()
|
|
msg := &telego.Message{MessageID: 1}
|
|
b, err := json.Marshal(msg)
|
|
require.NoError(t, err)
|
|
return &ta.Response{Ok: true, Result: b}
|
|
}
|
|
|
|
// newTestChannel creates a TelegramChannel with a mocked bot for unit testing.
|
|
func newTestChannel(t *testing.T, caller *stubCaller) *TelegramChannel {
|
|
t.Helper()
|
|
|
|
bot, err := telego.NewBot(testToken,
|
|
telego.WithAPICaller(caller),
|
|
telego.WithRequestConstructor(&stubConstructor{}),
|
|
telego.WithDiscardLogger(),
|
|
)
|
|
require.NoError(t, err)
|
|
|
|
base := channels.NewBaseChannel("telegram", nil, nil, nil,
|
|
channels.WithMaxMessageLength(4096),
|
|
)
|
|
base.SetRunning(true)
|
|
|
|
return &TelegramChannel{
|
|
BaseChannel: base,
|
|
bot: bot,
|
|
chatIDs: make(map[string]int64),
|
|
}
|
|
}
|
|
|
|
func TestSend_EmptyContent(t *testing.T) {
|
|
caller := &stubCaller{
|
|
callFn: func(ctx context.Context, url string, data *ta.RequestData) (*ta.Response, error) {
|
|
t.Fatal("SendMessage should not be called for empty content")
|
|
return nil, nil
|
|
},
|
|
}
|
|
ch := newTestChannel(t, caller)
|
|
|
|
err := ch.Send(context.Background(), bus.OutboundMessage{
|
|
ChatID: "12345",
|
|
Content: "",
|
|
})
|
|
|
|
assert.NoError(t, err)
|
|
assert.Empty(t, caller.calls, "no API calls should be made for empty content")
|
|
}
|
|
|
|
func TestSend_ShortMessage_SingleCall(t *testing.T) {
|
|
caller := &stubCaller{
|
|
callFn: func(ctx context.Context, url string, data *ta.RequestData) (*ta.Response, error) {
|
|
return successResponse(t), nil
|
|
},
|
|
}
|
|
ch := newTestChannel(t, caller)
|
|
|
|
err := ch.Send(context.Background(), bus.OutboundMessage{
|
|
ChatID: "12345",
|
|
Content: "Hello, world!",
|
|
})
|
|
|
|
assert.NoError(t, err)
|
|
assert.Len(t, caller.calls, 1, "short message should result in exactly one SendMessage call")
|
|
}
|
|
|
|
func TestSend_LongMessage_MultipleCalls(t *testing.T) {
|
|
caller := &stubCaller{
|
|
callFn: func(ctx context.Context, url string, data *ta.RequestData) (*ta.Response, error) {
|
|
return successResponse(t), nil
|
|
},
|
|
}
|
|
ch := newTestChannel(t, caller)
|
|
|
|
// Create a message over 4000 chars so it gets split into multiple chunks.
|
|
longContent := strings.Repeat("a", 4001)
|
|
|
|
err := ch.Send(context.Background(), bus.OutboundMessage{
|
|
ChatID: "12345",
|
|
Content: longContent,
|
|
})
|
|
|
|
assert.NoError(t, err)
|
|
assert.Greater(t, len(caller.calls), 1, "long message should be split into multiple SendMessage calls")
|
|
}
|
|
|
|
func TestSend_HTMLFallback_PerChunk(t *testing.T) {
|
|
callCount := 0
|
|
caller := &stubCaller{
|
|
callFn: func(ctx context.Context, url string, data *ta.RequestData) (*ta.Response, error) {
|
|
callCount++
|
|
// Fail on odd calls (HTML attempt), succeed on even calls (plain text fallback)
|
|
if callCount%2 == 1 {
|
|
return nil, errors.New("Bad Request: can't parse entities")
|
|
}
|
|
return successResponse(t), nil
|
|
},
|
|
}
|
|
ch := newTestChannel(t, caller)
|
|
|
|
err := ch.Send(context.Background(), bus.OutboundMessage{
|
|
ChatID: "12345",
|
|
Content: "Hello **world**",
|
|
})
|
|
|
|
assert.NoError(t, err)
|
|
// One short message → 1 HTML attempt (fail) + 1 plain text fallback (success) = 2 calls
|
|
assert.Equal(t, 2, len(caller.calls), "should have HTML attempt + plain text fallback")
|
|
}
|
|
|
|
func TestSend_HTMLFallback_BothFail(t *testing.T) {
|
|
caller := &stubCaller{
|
|
callFn: func(ctx context.Context, url string, data *ta.RequestData) (*ta.Response, error) {
|
|
return nil, errors.New("send failed")
|
|
},
|
|
}
|
|
ch := newTestChannel(t, caller)
|
|
|
|
err := ch.Send(context.Background(), bus.OutboundMessage{
|
|
ChatID: "12345",
|
|
Content: "Hello",
|
|
})
|
|
|
|
assert.Error(t, err)
|
|
assert.True(t, errors.Is(err, channels.ErrTemporary), "error should wrap ErrTemporary")
|
|
assert.Equal(t, 2, len(caller.calls), "should have HTML attempt + plain text attempt")
|
|
}
|
|
|
|
func TestSend_LongMessage_HTMLFallback_StopsOnError(t *testing.T) {
|
|
// With a long message that gets split into 2 chunks, if both HTML and
|
|
// plain text fail on the first chunk, Send should return early.
|
|
caller := &stubCaller{
|
|
callFn: func(ctx context.Context, url string, data *ta.RequestData) (*ta.Response, error) {
|
|
return nil, errors.New("send failed")
|
|
},
|
|
}
|
|
ch := newTestChannel(t, caller)
|
|
|
|
longContent := strings.Repeat("x", 4001)
|
|
|
|
err := ch.Send(context.Background(), bus.OutboundMessage{
|
|
ChatID: "12345",
|
|
Content: longContent,
|
|
})
|
|
|
|
assert.Error(t, err)
|
|
// Should fail on the first chunk (2 calls: HTML + fallback), never reaching the second chunk.
|
|
assert.Equal(t, 2, len(caller.calls), "should stop after first chunk fails both HTML and plain text")
|
|
}
|
|
|
|
func TestSend_NotRunning(t *testing.T) {
|
|
caller := &stubCaller{
|
|
callFn: func(ctx context.Context, url string, data *ta.RequestData) (*ta.Response, error) {
|
|
t.Fatal("should not be called")
|
|
return nil, nil
|
|
},
|
|
}
|
|
ch := newTestChannel(t, caller)
|
|
ch.SetRunning(false)
|
|
|
|
err := ch.Send(context.Background(), bus.OutboundMessage{
|
|
ChatID: "12345",
|
|
Content: "Hello",
|
|
})
|
|
|
|
assert.ErrorIs(t, err, channels.ErrNotRunning)
|
|
assert.Empty(t, caller.calls)
|
|
}
|
|
|
|
func TestSend_InvalidChatID(t *testing.T) {
|
|
caller := &stubCaller{
|
|
callFn: func(ctx context.Context, url string, data *ta.RequestData) (*ta.Response, error) {
|
|
t.Fatal("should not be called")
|
|
return nil, nil
|
|
},
|
|
}
|
|
ch := newTestChannel(t, caller)
|
|
|
|
err := ch.Send(context.Background(), bus.OutboundMessage{
|
|
ChatID: "not-a-number",
|
|
Content: "Hello",
|
|
})
|
|
|
|
assert.Error(t, err)
|
|
assert.True(t, errors.Is(err, channels.ErrSendFailed), "error should wrap ErrSendFailed")
|
|
assert.Empty(t, caller.calls)
|
|
}
|