From fc89fea319bb8d8cde70ea488965836edf0caac8 Mon Sep 17 00:00:00 2001
From: David Siewert <david1gruppenplan@gmail.com>
Date: Sat, 25 Apr 2026 21:14:06 +0600
Subject: [PATCH] test(utils): add unit tests for FormatArgsJSON

Add tests for FormatArgsJSON covering:
- Default compact JSON output
- Pretty print formatting
- HTML escape disabling (preserves &&, <, >)
- Combined pretty print and escape disable
- Default HTML escaping behavior
- Nil args handling
---
 pkg/utils/tool_feedback_test.go | 100 +++++++++++++++++++++++++++++++-
 1 file changed, 99 insertions(+), 1 deletion(-)

diff --git a/pkg/utils/tool_feedback_test.go b/pkg/utils/tool_feedback_test.go
index c30f53827..5fabd3d83 100644
--- a/pkg/utils/tool_feedback_test.go
+++ b/pkg/utils/tool_feedback_test.go
@@ -1,6 +1,9 @@
 package utils
 
-import "testing"
+import (
+	"encoding/json"
+	"testing"
+)
 
 func TestFormatToolFeedbackMessage(t *testing.T) {
 	got := FormatToolFeedbackMessage(
@@ -56,3 +59,98 @@ func TestFitToolFeedbackMessage_TruncatesSingleLineMessage(t *testing.T) {
 		t.Fatalf("FitToolFeedbackMessage() = %q, want %q", got, want)
 	}
 }
+
+func TestFormatArgsJSON_Defaults(t *testing.T) {
+	args := map[string]any{"path": "README.md", "line": 42}
+	got := FormatArgsJSON(args, false, false)
+	var gotVal, wantVal any
+	if err := json.Unmarshal([]byte(got), &gotVal); err != nil {
+		t.Fatalf("FormatArgsJSON() returned invalid JSON: %v", err)
+	}
+	want := `{"path":"README.md","line":42}`
+	if err := json.Unmarshal([]byte(want), &wantVal); err != nil {
+		t.Fatalf("invalid test want JSON: %v", err)
+	}
+	if !jsonValEq(gotVal, wantVal) {
+		t.Fatalf("FormatArgsJSON() = %q, want %q", got, want)
+	}
+}
+
+func TestFormatArgsJSON_PrettyPrint(t *testing.T) {
+	args := map[string]any{"path": "README.md", "line": 42}
+	got := FormatArgsJSON(args, true, false)
+	var gotVal any
+	if err := json.Unmarshal([]byte(got), &gotVal); err != nil {
+		t.Fatalf("FormatArgsJSON() returned invalid JSON: %v", err)
+	}
+	want := `{"path":"README.md","line":42}`
+	var wantVal any
+	if err := json.Unmarshal([]byte(want), &wantVal); err != nil {
+		t.Fatalf("invalid test want JSON: %v", err)
+	}
+	if !jsonValEq(gotVal, wantVal) {
+		t.Fatalf("FormatArgsJSON() prettyPrint = %q, want structure %q", got, want)
+	}
+}
+
+func TestFormatArgsJSON_DisableEscapeHTML(t *testing.T) {
+	args := map[string]any{"msg": "a < b && c > d"}
+	got := FormatArgsJSON(args, false, true)
+	var gotVal, wantVal any
+	want := `{"msg":"a < b && c > d"}`
+	if err := json.Unmarshal([]byte(got), &gotVal); err != nil {
+		t.Fatalf("FormatArgsJSON() returned invalid JSON: %v", err)
+	}
+	if err := json.Unmarshal([]byte(want), &wantVal); err != nil {
+		t.Fatalf("invalid test want JSON: %v", err)
+	}
+	if !jsonValEq(gotVal, wantVal) {
+		t.Fatalf("FormatArgsJSON() disableEscapeHTML = %q, want %q", got, want)
+	}
+}
+
+func TestFormatArgsJSON_PrettyPrintAndDisableEscapeHTML(t *testing.T) {
+	args := map[string]any{"msg": "a < b && c > d"}
+	got := FormatArgsJSON(args, true, true)
+	var gotVal, wantVal any
+	want := `{"msg":"a < b && c > d"}`
+	if err := json.Unmarshal([]byte(got), &gotVal); err != nil {
+		t.Fatalf("FormatArgsJSON() returned invalid JSON: %v", err)
+	}
+	if err := json.Unmarshal([]byte(want), &wantVal); err != nil {
+		t.Fatalf("invalid test want JSON: %v", err)
+	}
+	if !jsonValEq(gotVal, wantVal) {
+		t.Fatalf("FormatArgsJSON() combined = %q, want %q", got, want)
+	}
+}
+
+func TestFormatArgsJSON_EscapeHTMLByDefault(t *testing.T) {
+	args := map[string]any{"msg": "a < b && c > d"}
+	got := FormatArgsJSON(args, false, false)
+	var gotVal, wantVal any
+	want := `{"msg":"a \u003c b \u0026\u0026 c \u003e d"}`
+	if err := json.Unmarshal([]byte(got), &gotVal); err != nil {
+		t.Fatalf("FormatArgsJSON() returned invalid JSON: %v", err)
+	}
+	if err := json.Unmarshal([]byte(want), &wantVal); err != nil {
+		t.Fatalf("invalid test want JSON: %v", err)
+	}
+	if !jsonValEq(gotVal, wantVal) {
+		t.Fatalf("FormatArgsJSON() default escape = %q, want %q", got, want)
+	}
+}
+
+func TestFormatArgsJSON_NilArgs(t *testing.T) {
+	got := FormatArgsJSON(nil, false, false)
+	want := `null`
+	if got != want {
+		t.Fatalf("FormatArgsJSON() nil = %q, want %q", got, want)
+	}
+}
+
+func jsonValEq(a, b any) bool {
+	aJSON, _ := json.Marshal(a)
+	bJSON, _ := json.Marshal(b)
+	return string(aJSON) == string(bJSON)
+}