From 4290aa8b5bee7d2407ec1b40a163f3e54fb3de6c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=A8=8B=E6=99=BA=E8=B6=850668000959?= Date: Sat, 6 Jun 2026 21:34:09 +0800 Subject: [PATCH] fix: check Close() errors in updater extraction functions --- pkg/updater/updater.go | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/pkg/updater/updater.go b/pkg/updater/updater.go index 2d4cc950e..f8fc29fdf 100644 --- a/pkg/updater/updater.go +++ b/pkg/updater/updater.go @@ -584,8 +584,13 @@ func extractZip(archivePath, destDir string) error { out.Close() return err } - rc.Close() - out.Close() + if err := rc.Close(); err != nil { + out.Close() + return fmt.Errorf("close zip entry reader: %w", err) + } + if err := out.Close(); err != nil { + return fmt.Errorf("close extracted file %q: %w", target, err) + } } return nil } @@ -649,7 +654,9 @@ func extractTarFromReader(tr *tar.Reader, destDir string) error { out.Close() return err } - out.Close() + if err := out.Close(); err != nil { + return fmt.Errorf("close extracted file %q: %w", target, err) + } } } return nil