From bd867a16cdf664587f18b32a3011098f032f7ff5 Mon Sep 17 00:00:00 2001 From: SiYue-ZO <2835601846@qq.com> Date: Tue, 28 Apr 2026 12:58:26 +0800 Subject: [PATCH] style(tools): wrap serial lines for golines --- pkg/tools/hardware/serial.go | 8 ++++++-- pkg/tools/hardware/serial_test.go | 7 ++++++- 2 files changed, 12 insertions(+), 3 deletions(-) diff --git a/pkg/tools/hardware/serial.go b/pkg/tools/hardware/serial.go index 52e47fc7a..7e197a909 100644 --- a/pkg/tools/hardware/serial.go +++ b/pkg/tools/hardware/serial.go @@ -23,7 +23,9 @@ const ( ) var ( - unixSerialPortPattern = regexp.MustCompile(`^(?:/dev/)?(?:ttyS\d+|ttyUSB\d+|ttyACM\d+|ttyAMA\d+|rfcomm\d+|tty\.[A-Za-z0-9._-]+|cu\.[A-Za-z0-9._-]+)$`) + unixSerialPortPattern = regexp.MustCompile( + `^(?:/dev/)?(?:ttyS\d+|ttyUSB\d+|ttyACM\d+|ttyAMA\d+|rfcomm\d+|tty\.[A-Za-z0-9._-]+|cu\.[A-Za-z0-9._-]+)$`, + ) windowsSerialPortPattern = regexp.MustCompile(`^(?:\\\\\.\\)?COM[1-9]\d*$`) unixSerialBaudRates = map[int]struct{}{ 50: {}, 75: {}, 110: {}, 134: {}, 150: {}, 200: {}, 300: {}, 600: {}, 1200: {}, 1800: {}, @@ -219,7 +221,9 @@ func parseSerialConfig(args map[string]any) (serialConfig, *ToolResult) { port, ok := args["port"].(string) port = strings.TrimSpace(port) if !ok || port == "" { - return serialConfig{}, ErrorResult("port is required (for example /dev/ttyUSB0, /dev/cu.usbserial-0001, or COM3)") + return serialConfig{}, ErrorResult( + "port is required (for example /dev/ttyUSB0, /dev/cu.usbserial-0001, or COM3)", + ) } normalizedPort, err := normalizeSerialPort(port) diff --git a/pkg/tools/hardware/serial_test.go b/pkg/tools/hardware/serial_test.go index 5f9e2a44d..6b2e9765d 100644 --- a/pkg/tools/hardware/serial_test.go +++ b/pkg/tools/hardware/serial_test.go @@ -103,7 +103,12 @@ func TestSerialReadCanceledBeforeOpen(t *testing.T) { port = "COM3" } - _, err := serialRead(ctx, serialConfig{Port: port, Baud: 115200, DataBits: 8, Parity: "none", StopBits: 1}, 1, time.Second) + _, err := serialRead( + ctx, + serialConfig{Port: port, Baud: 115200, DataBits: 8, Parity: "none", StopBits: 1}, + 1, + time.Second, + ) if err == nil || !strings.Contains(err.Error(), context.Canceled.Error()) { t.Fatalf("serialRead() error = %v, want context canceled", err) }