From 6c882ec5e74bd1c58e2fac3698922bf333abfa25 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E7=A8=8B=E6=99=BA=E8=B6=850668000959?= Date: Sat, 6 Jun 2026 00:32:49 +0800 Subject: [PATCH] fix(agent): log warning when LoadAndDelete type assertion fails Add a warning log when the type assertion from sync.Map.LoadAndDelete fails in UnsubscribeEvents, per review suggestion. This makes a mismatched type observable for debugging. --- pkg/agent/legacy_events.go | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/pkg/agent/legacy_events.go b/pkg/agent/legacy_events.go index 33fdb32d8..794a5a330 100644 --- a/pkg/agent/legacy_events.go +++ b/pkg/agent/legacy_events.go @@ -2,11 +2,13 @@ package agent import ( "context" + "fmt" "sync" "sync/atomic" "github.com/sipeed/picoclaw/pkg/bus" runtimeevents "github.com/sipeed/picoclaw/pkg/events" + "github.com/sipeed/picoclaw/pkg/logger" ) const defaultEventSubscriberBuffer = 16 @@ -90,6 +92,10 @@ func (al *AgentLoop) UnsubscribeEvents(id uint64) { } sub, ok := value.(legacyEventSubscription) if !ok { + logger.WarnCF("agent", "UnsubscribeEvents: unexpected type in subscription map", map[string]any{ + "id": id, + "type": fmt.Sprintf("%T", value), + }) return } sub.cancel()