From 16a3b96ddebe4b1d75db05a19c6f36f814823118 Mon Sep 17 00:00:00 2001
From: yuchou87 <yuchou87@gmail.com>
Date: Sun, 22 Feb 2026 15:06:57 +0800
Subject: [PATCH] fix(mcp): validate workspace before resolving relative
 env_file

---
 pkg/mcp/manager.go | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/pkg/mcp/manager.go b/pkg/mcp/manager.go
index b28ba4670..90f31f0c1 100644
--- a/pkg/mcp/manager.go
+++ b/pkg/mcp/manager.go
@@ -161,6 +161,17 @@ func (m *Manager) LoadFromMCPConfig(ctx context.Context, mcpCfg config.MCPConfig
 
 			// Resolve relative envFile paths relative to workspace
 			if serverCfg.EnvFile != "" && !filepath.IsAbs(serverCfg.EnvFile) {
+				if workspace == "" {
+					err := fmt.Errorf("workspace path is empty while resolving relative envFile %q for server %s", serverCfg.EnvFile, name)
+					logger.ErrorCF("mcp", "Invalid MCP server configuration",
+						map[string]interface{}{
+							"server":   name,
+							"env_file": serverCfg.EnvFile,
+							"error":    err.Error(),
+						})
+					errs <- err
+					return
+				}
 				serverCfg.EnvFile = filepath.Join(workspace, serverCfg.EnvFile)
 			}