fix(onebot): tighten inbound media download handling

This commit is contained in:
lc6464
2026-06-17 16:35:54 +08:00
committed by Guoguo
parent 234bd03018
commit 1420875921
3 changed files with 7 additions and 13 deletions
+4 -1
View File
@@ -60,7 +60,10 @@ func TestCreateSafeHTTPClient_BlocksPrivateRedirect(t *testing.T) {
}
allowPrivateHosts = false
_, err = client.Get(server.URL)
resp, err := client.Get(server.URL)
if resp != nil && resp.Body != nil {
resp.Body.Close()
}
if err == nil {
t.Fatal("expected redirect to private host to fail")
}
+3 -2
View File
@@ -97,9 +97,10 @@ func DownloadFile(urlStr, filename string, opts DownloadOptions) string {
var client *http.Client
var err error
if opts.BlockPrivateTargets {
if err := ValidateSafeHTTPURL(urlStr, nil, nil); err != nil {
validateErr := ValidateSafeHTTPURL(urlStr, nil, nil)
if validateErr != nil {
logger.ErrorCF(opts.LoggerPrefix, "Blocked unsafe download URL", map[string]any{
"error": err.Error(),
"error": validateErr.Error(),
"url": urlStr,
})
return ""